[OHI-1065] [OHI-1090] fix(probeTool): Implement isPointNearTool so EraserTool can detect probe measurements and delete them, use line width value from config for drawing the probe circle #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The measurement eraser tool was not deleting probe measurements due to ProbeTool not having a isPointNearTool implementation. I have implemented the function so measurements can be detected and deleted.
The probe tool was also not using the line width set by users in the annotation configuration, it has now been fixed to use the value provided from the config.
Eraser fix:
Line width fix:
Closes OHI-1065 and OHI-1090
Closes #1304, #1181