feat(voi): add linear exact voi lut function #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
❌ Deploy Preview for cornerstone-3d-docs failed. Why did it fail? →
|
| const lower = windowCenter - 0.5 - (windowWidth - 1) / 2; | ||
| const upper = windowCenter - 0.5 + (windowWidth - 1) / 2; | ||
| if (windowWidth < 1 || windowCenter < 1) { | ||
| // use fallback |
There was a problem hiding this comment.
Please add a console.warn('Non DICOM standard compliant width/center", windowWidth, windowCenter)
| @@ -41,10 +41,18 @@ function toLowHighRange( | |||
| lower: number; | |||
| upper: number; | |||
| } { | |||
| const lower = windowCenter - 0.5 - (windowWidth - 1) / 2; | |||
| const upper = windowCenter - 0.5 + (windowWidth - 1) / 2; | |||
| if (windowWidth < 1 || windowCenter < 1) { | |||
There was a problem hiding this comment.
Only check windowWidth, the windowCenter should be allowed to be bigger.
|
|
||
| return { lower, upper }; | ||
| return { |
There was a problem hiding this comment.
Please add a comment:
// This definition is from the DICOM standard PS3.3
7 tasks
…ring and metadata processes - Added voiLUTFunction to viewport VOI settings in StackViewport and related utilities. - Updated window level calculations to consider voiLUTFunction for accurate range determination. - Enhanced metadata extraction to include voiLUTFunction from DICOM data. - Introduced new logit utility for improved sigmoid function handling in window level transformations. - Updated relevant types and interfaces to accommodate voiLUTFunction. This change improves the flexibility and accuracy of volume rendering based on user-defined LUT functions.
sedghi
changed the title
wayfarer3130
approved these changes
Dec 20, 2024
IbrahimCSAE
reviewed
Dec 20, 2024
| const imageIdIndex = Math.floor(imageIds.length / 2); | ||
| const imageId = imageIds[imageIdIndex]; | ||
| const voiLutModule = metaData.get('voiLutModule', imageId); | ||
| if (voiLutModule?.windowWidth && voiLutModule.windowCenter) { | ||
| if (voiLutModule && voiLutModule.windowWidth && voiLutModule.windowCenter) { | ||
| voi.voiLUTFunction = voiLutModule.voiLUTFunction; |
There was a problem hiding this comment.
this is not always defined, it's crashing tests in OHIF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related OHIF/Viewers#4298
related OHIF/Viewers#4538
This pull request includes an important update to the
toLowHighRangefunction in thepackages/core/src/utilities/windowLevel.tsfile. The change adds a conditional check to handle cases wherewindowWidthorwindowCenterare less than 1, providing a fallback calculation for theloweranduppervalues.Key change:
packages/core/src/utilities/windowLevel.ts: Added a conditional check in thetoLowHighRangefunction to handle cases wherewindowWidthorwindowCenterare less than 1, and provided a fallback calculation forloweranduppervalues.