Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LengthTool): _dragCallback element reference #1683

Closed

Conversation

alex-stout
Copy link
Contributor

@alex-stout alex-stout commented Dec 6, 2024

Fixes the LengthTool's _dragCallback() method to fix a missing element reference.

Also cleans up some typescript typing.

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

stackblitz bot commented Dec 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit d037601
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/6763057fd69f7400087f766f
😎 Deploy Preview https://deploy-preview-1683--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alex-stout alex-stout force-pushed the fix/length-tool-el-ref branch from 0c4c7df to d037601 Compare December 18, 2024 17:25
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the value of this PR

@alex-stout alex-stout closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants