fix(tools): Add support for additional region data types and length variants #1629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Update SUPPORTED_REGION_DATA_TYPES, SUPPORTED_LENGTH_VARIANT and SUPPORTED_PROBE_VARIANT in
packages/tools/src/utilities/getCalibratedUnits.ts
Given the dicom standards here, it would be beneficial to update the package with these values so as to allow dicom scans to reference the correct measurements.
Changes & Results
Relevant Dicom MetaData Tags
Before
After
Existing values will not be changed only added to. Therefore no change to exisiting functionality, only added support for dicom image metadata.
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-api
to update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment