Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yarn build when using Vite. #1556

Closed
wants to merge 2 commits into from

Conversation

sgielen
Copy link
Contributor

@sgielen sgielen commented Nov 6, 2024

Context

These are changes necessary to fix yarn build on the https://github.com/cornerstonejs/vue-cornerstone3d repo. PR likely still needs some work.

See also cornerstonejs/vue-cornerstone3d#1 for the other side, and vitejs/vite#18585 for the Vite bug report.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

Copy link

stackblitz bot commented Nov 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 762a274
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/672af16b2f6591000892c790
😎 Deploy Preview https://deploy-preview-1556--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sgielen sgielen marked this pull request as ready for review November 6, 2024 03:16
@sedghi
Copy link
Member

sedghi commented Nov 6, 2024

I don't think we need this anymore. Your help was invaluable in fixing Vite, and I really appreciate it. Check out the Vue recipe, which now builds and works in development.

@sedghi sedghi closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants