Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with ReferenceLinesTool #1387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Steven-DD
Copy link

In some medical imaging the "reference Lines Tool" does not get the intersection coordinates correctly with the "show Full Dimension" option turned on, causing the tool not to work properly.

I added a fallback action to it

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

In some medical imaging the "reference Lines Tool" does not get the intersection coordinates correctly with the "show Full Dimension" option turned on, causing the tool not to work properly.

I added a fallback action to it
Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for cornerstone-3d-docs ready!

Name Link
🔨 Latest commit 98915b9
🔍 Latest deploy log https://app.netlify.com/sites/cornerstone-3d-docs/deploys/668f59bf26c7de0008d996c9
😎 Deploy Preview https://deploy-preview-1387--cornerstone-3d-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi
Copy link
Member

sedghi commented Dec 4, 2024

Thanks for your PR. Could you provide a before-and-after image or share the specific data that is broken?

@Steven-DD
Copy link
Author

Thanks for your PR. Could you provide a before-and-after image or share the specific data that is broken?

I'm sorry I can't show you the full cause of this problem, as it was discovered during the development of a commercial software, but I can give you some screenshots and describe what I think is going wrong.

I'm not sure what the underlying cause of the problem is, but in some of the images I've encountered, turning on the ‘showFullDimension’ option calculates an incorrect coordinate, as shown in the following image

image

This problem can be solved by not using the 'showFullDimension' option, so I'm not sure if adding a fallback mechanism is a sensible solution, but at least this would allow the line to show instead of nothing happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants