Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Get rid of 12-year-old hack to add dynamic gem dependencies
The hack, which acts as a C-extensions which ain't one: https://en.wikibooks.org/wiki/Ruby_Programming/RubyGems#How_to_install_different_versions_of_gems_depending_on_which_version_of_ruby_the_installee_is_using The problem with this hack is: * it cannot pass build flags to depdent gems from bundler, i.e. ruby-debug-ide won't pass build.debase flags even though it triggers debase C-extension build as a dynamic dependency build.debase Set for the current user (/Users/kaka.dudu/.bundle/config): "--with-cflags=-Wno-error=incompatible-function-pointer-types" * it's 2024 and LMND does not make Ruby IDEs, for application scope we don't need this hack, it's drawbacks and static dependencies for a narrower scope of Ruby runtimes is super fine, especially when it reduces vast amount of problems that developers may experience TL;DR * don't add dynamic dependencies, monolith already specifies them explicitly group :development do gem 'debase', '0.2.5.beta2' gem 'ruby-debug-ide', github: 'lemonade-hq/ruby-debug-ide', branch: 'master' end Co-authored-by: Szymon Fiedler <[email protected]>
- Loading branch information