84 - HTTP Error code handling 400+ #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement hierarchical exception system with base NHLApiException - Add specific exceptions for common HTTP status codes (404, 429, 400, 401, 5xx) - Create centralized error handling in _handle_response method - Add comprehensive test suite with pytest for all error scenarios - Improve error message formatting to include both request context and API response - Handle edge cases for malformed JSON and non-JSON responses - Add type checking for response parsing Tests cover: - All HTTP error status codes - Success responses - Non-JSON responses - Malformed JSON handling - Query parameter handling - Verbose logging behavior Breaking changes: None - extends existing error handling functionality Closes #81
|
This is gonna get a minor bump due to touching code that affects every request. Im gonna test this via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Enhance HTTP client error handling with custom exceptions
Tests cover:
Breaking changes: None - extends existing error handling functionality