Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTX-5430: Coretex configuration centralization refactor. #167

Merged
merged 38 commits into from
Aug 13, 2024

Conversation

bogdant36
Copy link
Collaborator

Resolves CTX-5430.

Bogdan Tintor added 4 commits April 17, 2024 09:19
Bogdan Tintor added 2 commits April 17, 2024 16:58
# Conflicts:
#	coretex/cli/commands/node.py
#	coretex/cli/commands/project.py
#	coretex/cli/modules/config_defaults.py
#	coretex/cli/modules/node.py
#	coretex/cli/modules/project_utils.py
Bogdan Tintor added 2 commits May 16, 2024 09:51
# Conflicts:
#	coretex/cli/modules/node.py
# Conflicts:
#	coretex/cli/commands/login.py
#	coretex/cli/commands/node.py
#	coretex/cli/commands/task.py
#	coretex/cli/main.py
#	coretex/cli/modules/config_defaults.py
#	coretex/cli/modules/node.py
#	coretex/cli/modules/project_utils.py
#	coretex/cli/modules/ui.py
#	coretex/cli/modules/update.py
#	coretex/cli/modules/user.py
#	coretex/configuration.py
#	coretex/utils/__init__.py
#	coretex/utils/process.py

SOLVED CONFLICTS - > need to fix mypy right now and to test everything out.
Copy link
Collaborator

@dule1322 dule1322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these configuration changes backwards compatible? If not in _syncConfigWithEnv function detect if the old config file is present and split it into two so that the users with already created configuration do not need to reconfigure anything.

coretex/cli/commands/login.py Show resolved Hide resolved
coretex/configuration/base.py Outdated Show resolved Hide resolved
coretex/configuration/node.py Outdated Show resolved Hide resolved
coretex/configuration/node.py Outdated Show resolved Hide resolved
coretex/configuration/base.py Outdated Show resolved Hide resolved
Bogdan Tintor added 3 commits August 6, 2024 10:07
…ubles, ive added isConfigured checks in isConfigValid. More improvements, migration fix.
# Conflicts:
#	coretex/cli/commands/task.py
#	coretex/folder_manager.py
# Conflicts:
#	coretex/cli/commands/node.py
#	coretex/cli/modules/node.py

Fixed couple of found bugs.
coretex/cli/commands/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/project_utils.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/cli/commands/task.py Outdated Show resolved Hide resolved
coretex/cli/modules/project_utils.py Outdated Show resolved Hide resolved
coretex/configuration/node.py Outdated Show resolved Hide resolved
coretex/configuration/node.py Outdated Show resolved Hide resolved
coretex/configuration/node.py Outdated Show resolved Hide resolved
coretex/configuration/node.py Outdated Show resolved Hide resolved
coretex/configuration/user.py Outdated Show resolved Hide resolved
coretex/cli/commands/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/cli/modules/node.py Outdated Show resolved Hide resolved
coretex/configuration/config_defaults.py Outdated Show resolved Hide resolved
coretex/configuration/utils.py Outdated Show resolved Hide resolved
Bogdan Tintor added 2 commits August 9, 2024 14:09
# Conflicts:
#	coretex/utils/__init__.py
…red when they are supposed to and cause crash)
@dule1322 dule1322 merged commit 2771aa2 into coretex-ai:develop Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants