Skip to content

Commit

Permalink
CTX-6321: Discussion changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Bogdan Tintor committed Aug 26, 2024
1 parent 9fc11f3 commit 9566215
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion coretex/cli/commands/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ def config(advanced: bool) -> None:
nodeConfig = NodeConfiguration.load()
node_module.stop(nodeConfig.id)
except (ConfigurationNotFound, InvalidConfiguration):
node_module.stop(nodeConfig.id)
node_module.stop()

try:
nodeConfig = NodeConfiguration.load()
Expand Down
22 changes: 14 additions & 8 deletions coretex/cli/modules/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -497,17 +497,23 @@ def getNodeVersion() -> Optional[str]:
if isRunning():
imageName = docker.getContainerImageName(config_defaults.DOCKER_CONTAINER_NAME)

image_info = docker.imageInspect(imageName)
repo_digests = image_info.get("RepoDigests", [])
if not isinstance(repo_digests, list):
return 'Unknown version'
imageInfo = docker.imageInspect(imageName)
repoDigests = imageInfo.get("RepoDigests", [])
if not isinstance(repoDigests, list) and len(repoDigests) > 0:
return "Unknown version"

digest = repo_digests[0]
digest = repoDigests[0]
if not isinstance(digest, str):
# Assuming the format is "image_name@sha256:<digest>"
return "Unknown version"
else:
return digest.split("@")[1].split(":")[1][:12] if "@" in repo_digests[0] else "Unknown version"
return digest.split("@")[1].split(":")[1][:12] if "@" in repoDigests[0] else "Unknown version"

except ConfigurationNotFound:
ui.errorEcho("Node configuration not found.")

except InvalidConfiguration as ex:
for error in ex.errors:
ui.errorEcho(error)

except Exception as ex:
return f"Unable to retrieve version of Node. Reason: {ex}."
return f"Unable to retrieve version of Node"

0 comments on commit 9566215

Please sign in to comment.