-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e-upgrades: add basic tests with new rpm-ostree version #4784
Conversation
501de84
to
ffca388
Compare
7e8f254
to
e3b0be9
Compare
Test new rpm-ostree with kernel override, initramfs args, initramfs-etc, layering, overrides. See coreos#4776
e3b0be9
to
de79076
Compare
/retest |
@HuijingHei: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Confused about the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Three things from my side:
- IIUC, the first boot is already working from the new rpm-ostree (via
--oscontainer
passed to kola), but I think what we want is to create state from a node on the old rpm-ostree and then update on the new rpm-ostree. - Confusingly, IIUC the second boot is actually working from the old rpm-ostree, which is an interesting test (it verifies that state created by a new rpm-ostree does not break an old one). But a more natural test is upgrading to another update with the new rpm-ostree so that you can verify that new features are working correctly.
- Totally OK if you want to pursue this via the Prow harness. I personally think making this part of the other kola tests covered by CoreOS CI would make it more accessible and easier to maintain.
To fix 1, you'd probably want in the first boot to rollback to e.g. what's in testing-devel right now before creating state. To fix 2, you can do it the container way (export current commit to a container image, then create a new container image with some arbitrary change in it -- see e.g. this test) or the OSTree way (create a synthetic commit and rebase onto it -- see e.g. this test)
Yes, this is to add some basic tests with new rpm-ostree (via
Will look at it, thanks a lot @jlebon for your quick reply! Maybe we can have 2 tests about the upgrades, does this make sense?
|
I.e. in one test we do the mutations on top of old rpm-ostree and then upgrade, and in the other test, we upgrade first and then do the mutations? The first one sounds more interesting to me. What do you have in mind on what the second one is intended to catch? |
The second is to avoid regression of fedora-silverblue/issue-tracker#523, which upgrade rpm-ostree on old build, but hit issue when remove package. |
Close this as impl this in #4806 |
Test new rpm-ostree with kernel override, initramfs args, initramfs-etc, layering, overrides.
See #4776