This repository was archived by the owner on Sep 22, 2020. It is now read-only.
Open
Conversation
|
As the README says, this project has been deprecated since at least two years. If this is breaking any consumer, please migrate it to the official client instead. |
|
This project is used by registrator. We'd like to make these changes - or at least add some doco for how to work around them. |
|
I agree that this is the better solution. If there is a desire for "minimal change" then the polite thing to do is to help your users with a workaround. Please see the pull request here: #251 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
ugorji/go@54210f4
Causes this during build:
src/github.com/coreos/go-etcd/etcd/response.generated.go:242:27: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:261:28: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:326:26: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:572:27: too many arguments in call to r.Dec
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:1066:27: too many arguments in call to r.De
have ([]byte, bool, bool)
want ([]byte, bool)
src/github.com/coreos/go-etcd/etcd/response.generated.go:1379:14: cannot assign 1 values to 2 variab
src/github.com/coreos/go-etcd/etcd/response.generated.go:1494:21: cannot assign 1 values to 2 variab
I've regenerated response.generated.go and now it compiles. I did this to allow to compilation of gliderlabs/registrator: gliderlabs/registrator#591