-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi-arch-builders/tofu: Add PowerVs configuration #933
base: main
Are you sure you want to change the base?
Conversation
ravanelli
commented
Nov 27, 2023
- Add Tofu configuration for provisioning our ppc64le instance on PowerVs
- Include supplementary documentation for our Tofu and PowerVs procedures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! A few comments
@@ -0,0 +1,57 @@ | |||
# OpenTofu | |||
|
|||
OpenTofu is a Terraform fork, is an open-source infrastructure as code (IaC) tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize you copy/pasted this so it's an optional suggestion as it would require you to update both instances:
OpenTofu is a Terraform fork, is an open-source infrastructure as code (IaC) tool | |
OpenTofu, a Terraform fork, is an open-source infrastructure as code (IaC) tool |
variable "memory" { | ||
description = "Amount of memory (GB) to be allocated to the VM" | ||
default = "50" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just any number we want? For powerVS do they not have fixed instance sizes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same case for below
variable "processors" { | ||
description = "Number of virtual processors to allocate to the VM" | ||
default = "15" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
15 seems like a random number - would have expected a power of 2 (like 8 or 16) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each server model has a maximum allowable number, which may vary depending on utilization (interesting)
On the e880, the maximum core availability is now 12.04, reduced from the previous 15 I added here.
We now have on the e980, with 31.5. I will add a note in how to check it before ,so we may add the max we can.
} | ||
|
||
variable "network" { | ||
description = "List of networks that should be attached to the VM - Create this network before running terraform" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any instructions on how to create that network?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the internal docs, since it is for VPC. Not sure it is worth adding a general one here, maybe we won't need to create it without using VCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we ever wanted to do this for FCOS we'd need networks created? Can that be defined in tofu configuration? Let's add a comment somewhere to mention it and that it's a TODO item.
* Add Tofu configuration for provisioning our ppc64le instance on PowerVs * Include supplementary documentation for our Tofu and PowerVs procedures
# The PowerVs cost are high, check the price before adding | ||
# more processors and memory. This number may change | ||
# due the PowerVs availability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR I think our fcos ppc64le server only has 32G of memory so we could probably go down here if that makes sense if the costs are really high.
description = "Processor type for the LPAR - shared/dedicated" | ||
default = "capped" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description mentions shared/dedicated
as options but we have set it to capped
?
default = "15" | ||
} | ||
|
||
# The s922 model is the cheapest model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: for systemd_type and proc_type it might be useful to add a hyperlink to a place where there is a description of the options.