Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: temporarily disable kola-openstack in the pipeline #1062

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

marmijo
Copy link
Member

@marmijo marmijo commented Nov 22, 2024

All openstack runs started failing today due to #1061.
Stop running tests on openstack for the next few days to see if the issue is resolved after the weekend.

@dustymabe
Copy link
Member

looking at the code now it looks like another way to do this is to empty out the list in:

test_architectures: [x86_64, aarch64]

@marmijo
Copy link
Member Author

marmijo commented Nov 22, 2024

This should do the exact same thing since we don't run this test on RHCOS, but the config is probably a better place for this anyway. I'll make the change.

@dustymabe
Copy link
Member

dustymabe commented Nov 22, 2024

actually you might have to do something like [none] here

I'm not sure if the code will go into the if if the list is empty (i.e. does an empty list evaluate to false in groovy)

@marmijo marmijo force-pushed the temp-disable-openstack branch 2 times, most recently from ab5eafa to 47dd746 Compare November 22, 2024 22:13
@marmijo marmijo changed the title utils: temporarily disable kola-openstack in the pipeline config: temporarily disable kola-openstack in the pipeline Nov 22, 2024
@marmijo
Copy link
Member Author

marmijo commented Nov 22, 2024

I'm not sure if the code will go into the if if the list is empty (i.e. does an empty list evaluate to false in groovy)

It should be fine as test_architectures: [] : https://www.tutorialspoint.com/groovy/groovy_isempty.htm
EDIT, I see the question is actually a bit different than I understood. Let me investigate.

@marmijo
Copy link
Member Author

marmijo commented Nov 22, 2024

/hold

@marmijo marmijo force-pushed the temp-disable-openstack branch from 47dd746 to 0ee115d Compare November 22, 2024 22:25
@marmijo
Copy link
Member Author

marmijo commented Nov 22, 2024

/unhold
Yes, groovy will evaluate an empty list as false. I amended the commit to be test_architectures = [none] so the list will evaluate to true, but have no matching arches.

All openstack runs started failing today due to
coreos#1061
Stop running tests on openstack for the next few days to see
if the issue is resolved after the weekend.
@marmijo marmijo force-pushed the temp-disable-openstack branch from 0ee115d to 164a7ab Compare November 22, 2024 22:28
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe dustymabe merged commit e36f84e into coreos:main Nov 22, 2024
2 checks passed
@dustymabe
Copy link
Member

Yes, groovy will evaluate an empty list as false.

cool. yeah we should consider changing

if (pipecfg.clouds."${cloud}"?.test_architectures) {
to behave the way we expected it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants