Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-cosa: Add scheduled trigger to run weekly on Mondays/Wednesdays #1048

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ravanelli
Copy link
Member

  • Add a trigger for the Cosa build to execute at least twice a week (Mondays and Wednesdays);
  • This ensures regular builds even if no PRs, maintaining build continuity during periods of inactivity.

@ravanelli
Copy link
Member Author

It needs testing, to see if both triggers can coexist

 - Add a trigger for the Cosa build to execute
at least twice a week (Mondays and Wednesdays);
 - This ensures regular builds even if no PRs,
maintaining build continuity during periods of inactivity.

Signed-off-by: Renata Ravanelli <[email protected]>
@dustymabe
Copy link
Member

  • Add a trigger for the Cosa build to execute at least twice a week (Mondays and Wednesdays);

once a week would probably be sufficient if we wanted to simplify it. I would just schedule it for Monday morning, but fine with it the way you have it too.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

I guess one thing we should also make sure of is that older rhcos-4.XX branches don't get triggered this way.

@ravanelli
Copy link
Member Author

ravanelli commented Oct 21, 2024

I guess one thing we should also make sure of is that older rhcos-4.XX branches don't get triggered this way.

I will try to test it first before we merge it!

@ravanelli ravanelli marked this pull request as draft October 21, 2024 23:26
@jlebon
Copy link
Member

jlebon commented Oct 30, 2024

I guess one thing we should also make sure of is that older rhcos-4.XX branches don't get triggered this way.

As written, it wouldn't. It would only trigger builds with defaults set for all the parameters (which are set to build from main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants