-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlay.d & tests: Add alternatives migration and test #3253
base: testing-devel
Are you sure you want to change the base?
overlay.d & tests: Add alternatives migration and test #3253
Conversation
484d98b
to
2ba6b2a
Compare
2ba6b2a
to
086b0fa
Compare
- Add an overlay with the migration logic for alternatives - Add a test for the migration script This should make sure that the system is setup properly and that the migration script will do the right thing on older systems. See: coreos/fedora-coreos-tracker#1818 See: coreos/fedora-coreos-tracker#677 See: https://docs.fedoraproject.org/en-US/fedora-coreos/alternatives/
086b0fa
to
273dbde
Compare
I've now added the migration script to this PR and a test for it. Not fully tested yet. |
|
||
main() { | ||
# Should never happen as systemd checks this, but just in case | ||
if [[ ! -d "/var/lib/alternatives" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On silverblue, check /var/lib/alternatives
is broken link, should we care about this?
$ ls /var/lib/alternatives -al
lrwxrwxrwx. 1 root root 26 Oct 16 07:16 /var/lib/alternatives -> ../../usr/lib/alternatives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, if we want to have a single migration script for all variants then we should take this one into account.
overlay.d: Add empty statoverride config files
overlay.d & tests: Add alternatives migration and test
This should make sure that the system is setup properly and that the
migration script will do the right thing on older systems.
See: coreos/fedora-coreos-tracker#1818
See: coreos/fedora-coreos-tracker#677
See: https://docs.fedoraproject.org/en-US/fedora-coreos/alternatives/