tests/kola: adding the external kola test for luks + multipath case #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poorna-Gottimukkula1
changed the title
jlebon
reviewed
Aug 27, 2024
Poorna-Gottimukkula1
force-pushed
the
add-luks-multipath-ext-test
branch
2 times, most recently
from
a305f0c
to
178e930
Compare
|
CI is hitting:
We need to update the logic here to instead be something like (pseudo-code): |
Poorna-Gottimukkula1
force-pushed
the
add-luks-multipath-ext-test
branch
from
178e930
to
a19c7d0
Compare
jlebon
reviewed
Aug 30, 2024
Comment on lines
33
to
44
| if grep -q "rd.multipath=default" /proc/cmdline; then | ||
| if ! systemctl cat boot.mount | grep -q "What=/dev/disk/by-label/dm-mpath-boot"; then | ||
| systemctl cat boot.mount | ||
| fatal "boot is not mounted by /dev/disk/by-label/dm-mpath-boot" | ||
| fi | ||
| ok "boot mounted from /dev/disk/by-label/dm-mpath-boot" | ||
| else | ||
| if ! systemctl cat boot.mount | grep -q "What=/dev/disk/by-uuid"; then | ||
| systemctl cat boot.mount | ||
| fatal "boot is not mounted by UUID as expected" | ||
| fi | ||
| ok "boot mounted by UUID" |
There was a problem hiding this comment.
Looks like a good candidate to dedupe. E.g. something like
if grep ...; then
expected_what=/dev/disk/by-label/dm-mpath-boot
else
expected_what=/dev/disk/by-uuid
fi
if ! systemctl cat ...
There was a problem hiding this comment.
Updated the changes as per the above suggestion.
Poorna-Gottimukkula1
force-pushed
the
add-luks-multipath-ext-test
branch
from
a19c7d0
to
dd5c4e9
Compare
Yes, I have tested it on PowerPC and it got passed. |
Poorna-Gottimukkula1
force-pushed
the
add-luks-multipath-ext-test
branch
from
dd5c4e9
to
d52cfb9
Compare
jlebon
previously approved these changes
Sep 3, 2024
| ## kola: | ||
| ## # This test reprovisions the rootfs. | ||
| ## tags: "reprovision" | ||
| ## # This uses additionalDisks, which is QEMU only |
There was a problem hiding this comment.
This comment is incorrect. It's more like:
Suggested change
| ## # This uses additionalDisks, which is QEMU only | |
| ## # This uses appendKernelArgs and multipath, which is QEMU only |
Poorna-Gottimukkula1
force-pushed
the
add-luks-multipath-ext-test
branch
from
d52cfb9
to
4c39fda
Compare
Signed-off-by: Poorna Gottimukkula <[email protected]>
Poorna-Gottimukkula1
force-pushed
the
add-luks-multipath-ext-test
branch
from
4c39fda
to
79a976b
Compare
jlebon
approved these changes
Sep 4, 2024
I tested this only on FCOS as the RHCOS having issues in boot( Shell i build the RHCOS image with custom coreos-installer and try this out.? |
Ahh indeed. We're still on v0.21.0 there for some reason. Will inquire about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the external kola test for luks + multipath validation
ref: https://issues.redhat.com/browse/OCPBUGS-13123
coreos/fedora-coreos-tracker#1728