Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci & tests: Use registry.fedoraproject.org for Fedora container images #2988

Draft
wants to merge 2 commits into
base: testing-devel
Choose a base branch
from

Conversation

travier
Copy link
Member

@travier travier commented Apr 29, 2024

The plan is to keep using the registry.fedoraproject.org name but redirect it to quay.io.

Reverts: #2623

See: https://pagure.io/fedora-infrastructure/issue/11543

The plan is to keep using the registry.fedoraproject.org name but
redirect it to quay.io.

Reverts: coreos#2623

See: https://pagure.io/fedora-infrastructure/issue/11543
tests/kola/containers/quadlet/config.bu Outdated Show resolved Hide resolved
tests/kola/containers/quadlet/test.sh Outdated Show resolved Hide resolved
@c4rt0
Copy link
Member

c4rt0 commented Apr 29, 2024

Sorry - the above isn't that obvious. I'm referring to the fedora-minimal:39 which still feels outdated. I understand this is only addressing the registry.fedoraproject.org change - I am wondering if we could do both here?

@travier
Copy link
Member Author

travier commented Apr 29, 2024

Thanks! I'll add the 39->40 change to this PR.

c4rt0 added a commit to c4rt0/fedora-coreos-config that referenced this pull request Apr 29, 2024
@c4rt0
Copy link
Member

c4rt0 commented Apr 29, 2024

I'll add the 39->40 change to this PR.

Ah, sorry - I pushed the change before seeing your comment.

Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@travier
Copy link
Member Author

travier commented Apr 29, 2024

I'll add the 39->40 change to this PR.

Ah, sorry - I pushed the change before seeing your comment.

Looks like I pushed it right after :)

@jlebon
Copy link
Member

jlebon commented Apr 29, 2024

The only concern I have with this "redirect" plan is that it now makes our image pulls dependent on both registry.fedoraproject.org and Quay.io working, instead of just the latter. For that reason alone, I'd vote to just keep using Quay.io. ISTM like the main goal of the redirect approach is to not break existing docs/code, which is not a concern here since we've already done the work to move them over.

Commented in https://pagure.io/fedora-infrastructure/issue/11543#comment-907073.

@dustymabe
Copy link
Member

For that reason alone, I'd vote to just keep using Quay.io.

It's also weird because we push directly to quay for our FCOS images. Inconsistency isn't great.

@travier travier marked this pull request as draft April 30, 2024 14:46
@travier
Copy link
Member Author

travier commented Apr 30, 2024

Let's do #2990 first and then we'll see for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants