-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/dracut/ignition-ostree: add ignition-ostree-sysusers.service
#2679
base: testing-devel
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, though could we add an external test that tries to create a file owned by a user in a sysusers.d
dropin? (E.g. zincati
)
overlay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/ignition-ostree-sysusers.service
Outdated
Show resolved
Hide resolved
overlay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/coreos-sysroot-bwrap
Outdated
Show resolved
Hide resolved
Thanks @jlebon for the review! Do you mean like following (use
|
420c8f7
to
5bf0de4
Compare
@jlebon I am not sure how I can add special test for this patch, as all systemd sysusers are generated during build process, any pointers? Thanks! |
5bf0de4
to
e762ba8
Compare
This introduces a new `coreos-sysroot-bwrap` helper in initramfs, for binaries that need to be executed with the final sysroot as a target, but before the pivot-root happens.
This introduces a new `ignition-ostree-sysusers.service`, which takes care of poulating users and groups on the target sysroot before the Ignition `files` stage.
e762ba8
to
bd54cd7
Compare
Based on #774.
Copy text here:
This introduces a new
ignition-ostree-sysusers.service
, which takescare of poulating users and groups on the target sysroot before the
Ignition
files stage.