Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Inherit from Project Sagano #2610

Open
wants to merge 2 commits into
base: testing-devel
Choose a base branch
from

Conversation

cgwalters
Copy link
Member

@cgwalters cgwalters commented Sep 15, 2023

Depends #2609


manifests: Inherit from Project sagano

[This is just a demonstration/testing change; the git repository
for Sagano is definitely going to change location at least]

Fedora CoreOS predates the time of bootable containers. As such,
it's actually pretty large (relatively speaking). Project Sagano
is a fresh take on more minimal base images.

At the same time, we want to de-duplicate efforts. With this,
CoreOS cherry picks a few manifests from the Sagano "tier-0" and
"tier-1".

There's definitely more we can share between the two, but
this is a notable starting point.


@cgwalters cgwalters marked this pull request as draft September 15, 2023 22:06
@cgwalters cgwalters force-pushed the inherit-sagano branch 2 times, most recently from 0cc0eaf to b7ce9a0 Compare September 15, 2023 22:27
@cgwalters cgwalters changed the title Inherit sagano [demonstration only/WIP]: manifests: Inherit from Project sagano Sep 15, 2023
@cgwalters cgwalters force-pushed the inherit-sagano branch 4 times, most recently from be2da25 to 5cd60c6 Compare September 18, 2023 13:20
@cgwalters cgwalters changed the title [demonstration only/WIP]: manifests: Inherit from Project sagano [demonstration only/WIP]: manifests: Inherit from Project Sagano Sep 18, 2023
@cgwalters
Copy link
Member Author

The technology and social goals here are intertwined: once we merge this, we'll need to think: Should the relevant work be done in Sagano or in FCOS? The definite goal of this PR once it lands is that some of the maintenance work of FCOS actually becomes Sagano work, to be clear.

@cgwalters cgwalters added the area/container-native Work related to moving FCOS to be container-native label Sep 19, 2023
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is titled as demonstration only/WIP, but I think you do want feedback on the idea/direction.

Overall I think the direction is where we want to go in the future (i.e. some "core" thing in Fedora that all other OSTree/ContainerNative distros are based on) so 👍 for that. I do think it would be worth us discussing this more in a forum like the weekly community meeting to at least socialize the direction and to see what other people think.

Were you intending for this to merge soon? For right now I don't think I'd be super comfortable with making a change like this just because of the infancy of the project (i.e. the code name didn't even exist until a few weeks ago and it still lives under cgwalters-playground), but I think maybe once it gets more well established we could consider making a change like this?

.cci.jenkinsfile Outdated Show resolved Hide resolved
@cgwalters
Copy link
Member Author

Overall I think the direction is where we want to go in the future (i.e. some "core" thing in Fedora that all other OSTree/ContainerNative distros are based on) so 👍 for that.

Exactly, thanks!

I do think it would be worth us discussing this more in a forum like the weekly community meeting to at least socialize the direction and to see what other people think.

OK, though this is a developer-only focused change right now to be clear.

Were you intending for this to merge soon?

Definitely not, as the commit message says:

[This is just a demonstration/testing change; the git repository
for Sagano is definitely going to change location at least]

But it's intended to be a conversational starting point as the project progresses. Thanks for the feedback!

@dustymabe
Copy link
Member

OK, though this is a developer-only focused change right now to be clear.

Right. It's definitely not end user facing (hopefully), but it does have implications on our overall structure in the future, which I think raises to the level of being meeting worthy.

@jlebon
Copy link
Member

jlebon commented Sep 21, 2023

This looks sane to me too overall. I'm a bit confused though about https://gitlab.com/CentOS/cloud/sagano including both Fedora and CentOS manifests. ISTM like it'd be clearer to structure the repo as the common denominator and leave repo definitions and distro-specific stuff in one layer above? Ahh OK, I see https://gitlab.com/CentOS/cloud/sagano#plan, though I mean something slightly different. E.g.:

  • gitlab.com/<not sure>/sagano
    • inherited by https://github.com/fedora-base
      • inherited by https://github.com/coreos/fedora-coreos-config
      • inherited by https://pagure.io/workstation-ostree-config
      • ...
    • inherited by https://gitlab.com/CentOS/centos-base
      • inherited by https://gitlab.com/redhat/centos-stream/...
      • ...

?

That makes it easier for communities around each of Fedora and CentOS to work on their respective bases without incurring unnecessary churn on the other.

@cgwalters
Copy link
Member Author

To me an explicit goal is to fix the problem with Fedora CoreOS ➡️ ??? ➡️ RHEL CoreOS today.
And more generally, the drift between the 3 things without constant application of rigor...the fact that spec files need to be duplicated between fedora and c9s has caused me pain.

And specifically, a goal of Sagano is to be "ready to ship" even in CentOS Stream 9.

Another related goal is sharing tooling with things like automotive that only have CentOS versions at the moment. Also not unrelated to this, a goal is to build on the momentum from RHT investment in gitlab.com at an OS level and the CI flows there. And to help build the story with integration into dist-git gating.

With these things combined, splitting things up between Fedora and CentOS adds more friction to my mind. Particularly to the scale of all the git repositories you're proposing!

But obviously for now, fedora-coreos-config continues to be in github. That still works fine.

And more generally remember, a bigger goal here is that we do container native derivation which works just great today with Dockerfile etc. (and we have coreos/rpm-ostree#4427 to do). So the git repository structure is irrelevant to those; this is more about sharing code for "base image" builds (which does get into the more tricky topic of how we "productize" building custom base images, which we know we need).

@cgwalters
Copy link
Member Author

cgwalters commented Sep 21, 2023

A simple thing to game out: What happens when in e.g. fedora rawhide something changes in say the grub/systemd/whatever packaging and we need a change that's rawhide only in the manifest? How does that work? Do we branch in that git repository?

My first response here is that we already have some support for conditionals and rather than git branches we should make it work like spec files.

Will this cause problems? Maybe. But, my feeling is that that cost is going to be dramatically outweighed by the benefits of not allowing things to drift by default and keeping things centralized. EDIT: Right now every PR to the sagano Git is gating on Fedora 38 and C9S, and I think that's a really nice improvement.

@cgwalters cgwalters changed the title [demonstration only/WIP]: manifests: Inherit from Project Sagano manifests: Inherit from Project Sagano Oct 23, 2023
@cgwalters cgwalters marked this pull request as ready for review October 23, 2023 13:31
@cgwalters
Copy link
Member Author

OK, the sagano git repository is now in a more stable place; lifting draft on this.

@jlebon
Copy link
Member

jlebon commented Oct 26, 2023

SGTM. Though maybe let's wait until we've cleared f39 GA first?

Also, let's do #2609 first? (Did you see the comments there BTW?)

This is prep for rebasing on [sagano](https://gitlab.com/cgwalters-playground/sagano)
where I hit on the issue that to build images with `kernel-rt`,
we need to clearly separate the `kernel` package from userspace
stuff (`systemd`, `rpm-ostree`) etc.

Note that we'll need to make the same change in RHCOS - until
we rebase both on sagano.
Fedora CoreOS predates the time of bootable containers.  As such,
it's actually pretty large (relatively speaking).  Project Sagano
is a fresh take on more minimal base images.

At the same time, we want to de-duplicate efforts.  With this,
CoreOS cherry picks a few manifests from the Sagano "tier-0" and
"tier-1".

There's *definitely* more we can share between the two, but
this is a notable starting point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/container-native Work related to moving FCOS to be container-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants