-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Dynamically load ignition and afterburn from rootfs #1834
Draft
cgwalters
wants to merge
1
commit into
coreos:testing-devel
Choose a base branch
from
cgwalters:dynamic-fetch-ignition-afterburn
base: testing-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
...b/dracut/modules.d/40ignition-ostree/ignition-ostree-firstboot-populate-initramfs.service
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
[Unit] | ||
Description=Ignition OSTree: Populate initramfs for Ignition | ||
DefaultDependencies=false | ||
# Any services looking at mounts need to order after (or before) this | ||
# because it causes device re-probing. | ||
Before=coreos-gpt-setup.service | ||
# Also this one is probing disks | ||
Before=coreos-unique-boot.service | ||
# On the ignition boot, we must have a device labeled `root`. | ||
Wants=systemd-udevd.service | ||
After=systemd-udevd.service | ||
Requires=dev-disk-by\x2dlabel-root.device | ||
After=dev-disk-by\x2dlabel-root.device | ||
# We need to run before any services which execute: | ||
# - /usr/bin/ignition | ||
# - /usr/bin/afterburn | ||
Before=ignition-fetch.service | ||
Before=afterburn-network-kargs.service | ||
ConditionKernelCommandLine=ostree | ||
OnFailure=emergency.target | ||
OnFailureJobMode=isolate | ||
|
||
[Service] | ||
Type=oneshot | ||
RemainAfterExit=yes | ||
# So we can transiently mount sysroot | ||
MountFlags=slave | ||
ExecStart=/usr/libexec/ignition-ostree-transposefs populate-initramfs-pre-ignition |
19 changes: 19 additions & 0 deletions
19
.../dracut/modules.d/40ignition-ostree/ignition-ostree-subsequent-populate-initramfs.service
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
[Unit] | ||
Description=Ignition OSTree: Populate initramfs (subsequent boot) | ||
After=initrd-root-fs.target | ||
# We need to run before any services which execute: | ||
# - /usr/bin/ignition | ||
# - /usr/bin/afterburn | ||
Before=afterburn-hostname.service | ||
# This ensures we don't duplicate work on firstboot | ||
ConditionPathExists=!/usr/bin/ignition | ||
ConditionKernelCommandLine=ostree | ||
OnFailure=emergency.target | ||
OnFailureJobMode=isolate | ||
|
||
[Service] | ||
Type=oneshot | ||
RemainAfterExit=yes | ||
# So we can transiently mount sysroot | ||
MountFlags=slave | ||
ExecStart=/usr/libexec/ignition-ostree-transposefs populate-initramfs-subsequent |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this hacky bit relies on the fact that we depend on the afterburn and dracut modules, which will have installed the binaries first, then we remove them.