Skip to content

fix: auto-approve workflow, related to --slurp incopatibility - #4634

Merged
joelcapitao merged 1 commit into
coreos:mainfrom
c4rt0:fix-auto-approve-slurp
Oct 5, 2026
Merged

joelcapitao merged 1 commit into
coreos:mainfrom
c4rt0:fix-auto-approve-slurp

Conversation

@c4rt0

@c4rt0 c4rt0 commented Oct 5, 2026

Copy link
Copy Markdown
Member

Since:

the `--slurp` option is not supported with `--jq` or `--template`

Piping it to jq separately.

Fixes the failure introduced in #4633.

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: coreos/coreos-assembler/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e85ebd03-bb09-4e62-bd6c-51e56b41c811
📥 Commits

Reviewing files that changed from the base of the PR and between 4682ffe and 21a1e6d.

📒 Files selected for processing (1)
  • .github/workflows/auto-approve-lockfile.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the automated lockfile approval workflow to approve changes only when the complete pull request file list matches the API’s reported file count and every file is marked as modified. Automatic approval is now limited to changes involving rpms.lock.yaml; architecture-specific manifest lockfiles are no longer included. These changes affect repository maintenance workflows, not app features.

Walkthrough

The auto-approval workflow combines paginated pull request file results, checks that the list is nonempty and matches the API’s changed_files count, and limits its allowlist to rpms.lock.yaml. It still requires each listed file to have status modified.

Changes

Lockfile workflow

Layer / File(s) Summary
Validate lockfile changes
.github/workflows/auto-approve-lockfile.yml
The workflow combines paginated file-list results and exits with an error if the list is empty or its length does not match changed_files. The allowlist now includes only rpms.lock.yaml; the modified-status check remains.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: joelcapitao

Merge Risk: ⚪ Minimal · up to 21a1e

No actionable merge risk was found in the reviewed workflow changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the auto-approve workflow fix and the --slurp incompatibility addressed by the pull request.
Description check ✅ Passed The description explains that the workflow pipes output to jq separately to address the --slurp incompatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@c4rt0
c4rt0 marked this pull request as ready for review October 5, 2026 16:19
@c4rt0
c4rt0 enabled auto-merge (rebase) October 5, 2026 16:22
Comment thread .github/workflows/auto-approve-lockfile.yml
Comment thread .github/workflows/auto-approve-lockfile.yml Outdated
gh api does not support --slurp and --jq together. Pipe to jq
separately instead.

Also fix --argjson failure by replacing with shell arithmetic
comparison, and remove manifest-lock.* from the allowlist (this
repo only uses rpms.lock.yaml).

Assisted-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@c4rt0
c4rt0 force-pushed the fix-auto-approve-slurp branch from 4682ffe to 21a1e6d Compare October 5, 2026 19:53
@c4rt0

c4rt0 commented Oct 5, 2026

Copy link
Copy Markdown
Member Author

@joelcapitao, thanks for the review!

@joelcapitao
joelcapitao disabled auto-merge October 5, 2026 19:59

@joelcapitao joelcapitao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be good now

@joelcapitao
joelcapitao merged commit 08b6212 into coreos:main Oct 5, 2026
2 of 10 checks passed
@c4rt0
c4rt0 deleted the fix-auto-approve-slurp branch October 5, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants