Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kola: really make requiredTag required #3710

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jan 31, 2024

Before, even though a test had a required tag, explicitly passing a pattern which matched that test name would still include it. I thought that would be convenient, but it makes the logic less predictable. Since we don't use many required tags today, let's instead opt for being more explicit and always actually require the tag.

Motivated by coreos/rpm-ostree#4806 (comment).

Before, even though a test had a required tag, explicitly passing a
pattern which matched that test name would still include it. I thought
that would be convenient, but it makes the logic less predictable. Since
we don't use many required tags today, let's instead opt for being more
explicit and always actually require the tag.

Motivated by coreos/rpm-ostree#4806 (comment).
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Changing the logic in here is always tricky since it's pretty complicated but YOLO.

@jlebon jlebon enabled auto-merge (rebase) January 31, 2024 16:35
@jlebon jlebon merged commit bc4f3ac into coreos:main Jan 31, 2024
5 checks passed
@jlebon jlebon deleted the pr/tag-required-really branch January 31, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants