Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kola/testiso: enable 4k images tests for s390x #3574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kola/testiso: enable 4k images tests for s390x #3574

wants to merge 1 commit into from
+5 −5

Conversation

nikita-dubrovskii
Copy link
Contributor

@nikita-dubrovskii nikita-dubrovskii commented Aug 22, 2023 •
edited
Loading 

$ cosa kola testiso -S --qemu-native-4k --qemu-multipath  --output-dir tmp/kola-testiso-metal

⏭️  Skipping kola test pattern "fcos.internet":
  👉 https://github.com/coreos/coreos-assembler/pull/1478
⏭️  Skipping kola test pattern "podman.workflow":
  👉 https://github.com/coreos/coreos-assembler/pull/1478
Ignoring verification of signature on metal image
Running test: iso-live-login.s390fw
PASS: iso-live-login.s390fw (13.86s)
Running test: iso-live-login.4k.s390fw
PASS: iso-live-login.4k.s390fw (13.245s)
Running test: iso-offline-install.s390fw
PASS: iso-offline-install.s390fw (46.925s)
Running test: iso-offline-install.4k.s390fw
PASS: iso-offline-install.4k.s390fw (45.83s)
Running test: iso-offline-install.mpath.s390fw
PASS: iso-offline-install.mpath.s390fw (47.561s)
Running test: pxe-online-install.s390fw
PASS: pxe-online-install.s390fw (35.406s)
Running test: pxe-online-install.4k.s390fw
PASS: pxe-online-install.4k.s390fw (40.085s)
Running test: pxe-offline-install.s390fw
PASS: pxe-offline-install.s390fw (48.966s)
Running test: pxe-offline-install.4k.s390fw
PASS: pxe-offline-install.4k.s390fw (48.873s)
Running test: miniso-install.s390fw
PASS: miniso-install.s390fw (47.588s)
Running test: miniso-install.4k.s390fw
PASS: miniso-install.4k.s390fw (47.149s)
Running test: miniso-install.nm.s390fw
PASS: miniso-install.nm.s390fw (51.022s)
Running test: miniso-install.4k.nm.s390fw
PASS: miniso-install.4k.nm.s390fw (51.009s)
+ rc=0

This issue seems to be obsolete, but we still have to wait for a new coreos-installer.rpm

Depends on: ibm-s390-linux/s390-tools#154

@nikita-dubrovskii nikita-dubrovskii changed the title kola/testiso: enable 4k images tests for s390x WIP: kola/testiso: enable 4k images tests for s390x Aug 22, 2023
dustymabe
dustymabe previously approved these changes Aug 22, 2023
View reviewed changes
mantle/cmd/kola/testiso.go Outdated Show resolved Hide resolved
mantle/cmd/kola/testiso.go Outdated Show resolved Hide resolved
@nikita-dubrovskii nikita-dubrovskii changed the title WIP: kola/testiso: enable 4k images tests for s390x kola/testiso: enable 4k images tests for s390x Aug 23, 2023
@nikita-dubrovskii nikita-dubrovskii added hold waiting on something and removed needs-rebase labels Aug 23, 2023
dustymabe
dustymabe approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Member

any reason we have the hold label on this?

@jlebon
Copy link
Member

jlebon commented May 3, 2024

any reason we have the hold label on this?

Probably because of:

Depends on: ibm-s390-linux/s390-tools#154

@nikita-dubrovskii
Copy link
Contributor Author

coreos/fedora-coreos-tracker#1434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

Assignees
No one assigned
Labels
hold waiting on something
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikita-dubrovskii @dustymabe @jlebon @openshift-merge-robot