Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update statmentId for the cloudwatch integrations[CDS-1408] #110

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

guyrenny
Copy link
Contributor

Description

When user passes a log group longer than 70 characters, then he will hit a limit to the permission length in the cloudwatch integration, Update the StatementId for the cloudwatch integration so if the log group is longer than 70 characters then it will slice it to avoid this issue.

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the versions in the SemanticVersion in template.yaml
  • I have updated the CHANGELOG.md
  • I have created necessary PR to Terraform Module Repository (https://github.com/coralogix/terraform-coralogix-aws) if needed
  • This change does not affect any particular component (e.g. it's CI or docs change)

@guyrenny guyrenny requested a review from a team as a code owner July 30, 2024 07:46
custom-resource/index.py Outdated Show resolved Hide resolved
custom-resource/index.py Show resolved Hide resolved
@guyrenny guyrenny added the run-test-CloudWatch-test-blocking-pattern run cloudwatch e2e test label Jul 30, 2024
@guyrenny guyrenny requested a review from daidokoro July 30, 2024 10:51
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@guyrenny guyrenny merged commit 7a63535 into master Jul 30, 2024
10 checks passed
@guyrenny guyrenny deleted the cds-1408 branch July 30, 2024 11:28
@guyrenny guyrenny added enhancement New feature or request and removed run-test-CloudWatch-test-blocking-pattern run cloudwatch e2e test labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants