Rework handling of vernac state #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
approved these changes
Jul 15, 2023
maximedenes
force-pushed
the
fix-goals-global-env
branch
from
00e4c7d
to
4fab37e
Compare
maximedenes
changed the title
|
The idea of this PR is that public functions which call imperative APIs from Coq (printing, pretyping, internalization) should take a vernacstate and unfreeze it explicitly. Note that this is just a first step towards this goal, as some functions still implicitly rely on |
maximedenes
force-pushed
the
fix-goals-global-env
branch
from
4fab37e
to
e3b73ec
Compare
rtetley
reviewed
Aug 1, 2023
| @@ -11,12 +11,31 @@ | |||
| (* See LICENSE file. *) | |||
| (* *) | |||
| (**************************************************************************) | |||
| type hyp = { | |||
| identifiers: string list; | |||
| type_ : string; | |||
There was a problem hiding this comment.
@maximedenes is this a typo ? Or is it meant to be called type_ ? It currently breaks hypothesis display in the goal view: where should I change it, in the language-server or in the client ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513