depend on sel 0.4.0 #512
Merged
depend on sel 0.4.0 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI related commit is only partial, you get the log of the initialization phase but not the log that follows it. |
Closed
3 tasks
|
Could we depend on sel rather than vendoring it? From the description, it is not clear to me if the bugs you mention are fixed in sel 0.4.0. |
|
If you fix nix we can stop vendoring it |
|
To clarify, the bug was not there before the PR and is not introduced by the final version of this PR. |
|
The last two commits look unrelated to me, I'll move them to a separate PR. |
|
I opened NixOS/nixpkgs#247479 so that we can really unvendor sel. |
thanks! |
maximedenes
force-pushed
the
unvendor-sel
branch
from
a44e1d9
to
595c194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It finally works locally.
The main bug I introduced with the porting is that recurring events are no more available, one has to add the event back in the todo list by hand. Since I got it wrong, I was adding the lsp event twice and the code of SEL was not resilient to multiple events on the same file descriptor. I made the library resilient to that programming mistake in master.
The funny thing is that one event was reading even characters, the other odd characters, and both were hence failing to parse the content-length header.