Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an option to show dependencies between modules only #140

Open
wants to merge 2 commits into
base: coq-master
Choose a base branch
from

Conversation

MSoegtropIMC
Copy link

This PR adds an option to show dependencies between modules - that is all nodes and edges with the same module path are coerced into one. This is useful to analyse large projects.

Note that module dependencies can somehow by cyclic (not sure why but I saw one case in CoRN) which the existing transitive reduction code could not handle, so I replaced it with the transitive reduction function from the Graph library.

I did run make test and see 3 deviations, but I see the same deviations in coq-master with 8.20. One is about renaming Coq to Rocq, the others are likely cause by changes in the standard library.

@ybertot
Copy link
Collaborator

ybertot commented Jan 29, 2025

I am currently studying this pull request. I think we should add some documentation in the README.md file and some tests. I will do it when I have time, but don't hesitate adding stuff in this regard if you have some handy.

@ybertot ybertot self-requested a review January 29, 2025 07:34
@MSoegtropIMC
Copy link
Author

Thanks! For sure I can add documentation and tests. I am also thinking about some extensions, say grouping modules by module path prefix and some options on which part of the module path is shown in the graph, but this can also be done in a second step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants