fix: Only fix Windows console with Colorama #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
- Coverage 97.41% 97.20% -0.21%
==========================================
Files 48 48
Lines 4327 4327
==========================================
- Hits 4215 4206 -9
- Misses 112 121 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
908c090 broke the CI it seems. Gotta fix that. |
celm1990
added a commit
to celm1990/copier
that referenced
this pull request
Nov 11, 2023
After this PR copier-org#1379 method `just_fix_windows_console` is used instead of `init` So is need install `colorama>=0.4.6` because this method is add in commit tartley/colorama@5f1794d otherwise raise error AttributeError: module 'colorama' has no attribute 'just_fix_windows_console'
celm1990
added a commit
to celm1990/copier
that referenced
this pull request
Nov 11, 2023
After this PR copier-org#1379 method `just_fix_windows_console` is used instead of `init` So is need install `colorama>=0.4.6` because this method is add in commit tartley/colorama@5f1794d otherwise raise error AttributeError: module 'colorama' has no attribute 'just_fix_windows_console'
sisp
pushed a commit
that referenced
this pull request
Nov 11, 2023
After this PR #1379 method `just_fix_windows_console` is used instead of `init` So is need install `colorama>=0.4.6` because this method is add in commit tartley/colorama@5f1794d otherwise raise error AttributeError: module 'colorama' has no attribute 'just_fix_windows_console'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1378
Not sure how to test this.