Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the team page for 2024 #58

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Update the team page for 2024 #58

merged 11 commits into from
Jan 17, 2024

Conversation

lhvy
Copy link
Collaborator

@lhvy lhvy commented Jan 17, 2024 •
edited
Loading

Resolves #51
Resolves #24

  • Add the 2024 team
  • Remove old nominees
  • Update spacing for team/nominees
  • Hide nominations and merch pages from scrapers
  • Fix description and animation for nominees

@lhvy lhvy added the enhancement New feature or request label Jan 17, 2024
@lhvy lhvy self-assigned this Jan 17, 2024
@lhvy lhvy enabled auto-merge (squash) January 17, 2024 07:14
scorpiontornado
scorpiontornado reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@scorpiontornado scorpiontornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically ready to merge, minor things to consider first

data/NominationsData.old.js Show resolved Hide resolved
data/TeamData.js Show resolved Hide resolved
data/TeamData.js Show resolved Hide resolved
pages/passwords.jsx Outdated Show resolved Hide resolved
pages/team.jsx Outdated Show resolved Hide resolved
@scorpiontornado
Copy link
Collaborator

& coauthor me on the spacing commit plz 🙏

@lhvy lhvy disabled auto-merge January 17, 2024 14:07
scorpiontornado
scorpiontornado reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@scorpiontornado scorpiontornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

components/team/ExecCard.jsx Outdated Show resolved Hide resolved
components/team/ExecCard.jsx Outdated Show resolved Hide resolved
@lhvy lhvy enabled auto-merge (squash) January 17, 2024 14:07
@lhvy lhvy disabled auto-merge January 17, 2024 14:08
@lhvy lhvy enabled auto-merge (squash) January 17, 2024 14:08
scorpiontornado
scorpiontornado approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@scorpiontornado scorpiontornado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick 👍

@lhvy lhvy merged commit 635c41e into main Jan 17, 2024
1 check passed
@lhvy lhvy deleted the exec-2024 branch January 17, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scorpiontornado scorpiontornado scorpiontornado approved these changes

Assignees

@lhvy lhvy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update exec list for 2024 Fix exec descriptions not visible
2 participants
@lhvy @scorpiontornado