Merge pull request #1 from coopiteasy/9.0-provelo-overtime-access-rights

[ADD] hr_timesheet_overtime: access rights on page overtime
coopiteasy · Apr 1, 2020 · 29cc1df · 29cc1df
2 parents 08fedaf + 986f94c
commit 29cc1df
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/hr_timesheet_overtime/models/hr_employee.py b/hr_timesheet_overtime/models/hr_employee.py
@@ -32,6 +32,28 @@ class HrEmployee(models.Model):
         help="Overtime Start Date to compute overtime",
     )
 
+    has_overtime_access = fields.Boolean(
+        string="Has access to overtime page",
+        compute="_compute_has_overtime_access",
+    )
+
+    @api.multi
+    def _compute_has_overtime_access(self):
+        for rec in self:
+            has_access = False
+            if self.env.user.has_group(
+                "base.group_hr_manager"
+            ) or self.env.user.has_group("base.group_hr_user"):
+                has_access = True
+            elif (
+                rec.user_id.employee_ids.parent_id.id
+                == self.env.user.employee_ids.id
+            ):
+                has_access = True
+            elif rec.user_id == self.env.user:
+                has_access = True
+            rec.has_overtime_access = has_access
+
     @api.multi
     def _compute_total_overtime(self):
         """

diff --git a/hr_timesheet_overtime/views/hr_employee_view.xml b/hr_timesheet_overtime/views/hr_employee_view.xml
@@ -10,9 +10,12 @@
         <field name="inherit_id" ref="hr.view_employee_form"/>
         <field name="arch" type="xml">
             <xpath expr="//notebook" position="inside">
-                <page name="overtime" string="Overtime">
+                <page name="overtime"
+                      string="Overtime"
+                      attrs="{'invisible': [('has_overtime_access', '=', False)]}">
                     <group>
-                        <group name="overtime" string="Overtime" groups="base.group_hr_user">
+                        <group name="overtime" string="Overtime">
+                            <field name="has_overtime_access" invisible="True"/>
                             <field name="initial_overtime" widget="float_time"/>
                             <field name="total_overtime" widget="float_time"/>
                             <field name="overtime_start_date"/>