[16.0][MIG] pos_customer_wallet #300

carmenbianca · 2023-07-11T14:13:55Z

Description

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=10799&action=475&active_id=492&model=project.task&view_type=form&menu_id=536

Checklist before approval

Tests are present (or not needed).
Credits/copyright have been changed correctly.
Change log snippet is present.
(If a new module) Moving this to OCA has been considered.

codecov-commenter · 2023-09-07T09:49:12Z

Codecov Report

Merging #300 (8772350) into 16.0 (b640076) will decrease coverage by 3.22%.
Report is 19 commits behind head on 16.0.
The diff coverage is 86.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             16.0     #300      +/-   ##
==========================================
- Coverage   97.73%   94.52%   -3.22%     
==========================================
  Files          12       26      +14     
  Lines         221      347     +126     
  Branches       30       39       +9     
==========================================
+ Hits          216      328     +112     
- Misses          1       15      +14     
  Partials        4        4

Files Changed	Coverage Δ
pos_customer_wallet/models/pos_session.py	`40.00% <40.00%> (ø)`
pos_customer_wallet/models/pos_config.py	`58.33% <58.33%> (ø)`
account_customer_wallet/tests/common.py	`94.11% <100.00%> (+0.17%)`	⬆️
pos_customer_wallet/__init__.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/models/__init__.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/models/pos_payment_method.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/models/res_partner.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/tests/__init__.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/tests/common.py	`100.00% <100.00%> (ø)`
pos_customer_wallet/tests/test_balance.py	`100.00% <100.00%> (ø)`

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

….config Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…t payment method Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…stead of settings Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…ines This does not yet live-update in the POS. The window needs to be reloaded to see the updated balance. Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

… balance Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…ner._invoice_total algorithm Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…r account is set instead Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…ly tree Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…thout perms Previously there was a permission error on trying to read the `account.bank.statement.line` model. Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

base_suspend_security's functionality is wrapped into Odoo's sudo by default

This change was also done in account_customer_wallet. It simplifies things. This change is necessary for the 16.0 migration, but is not included in its commit for clarity's sake. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…t computation The pos session does not create these anymore. It creates pos.payment records instead. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

…ssion Signed-off-by: Carmen Bianca BAKKER <[email protected]>

legalsylvain · 2024-05-27T12:29:54Z

I have to review this one ! thanks for the ping !

polchampion · 2024-09-18T13:48:01Z

@carmenbianca à combien d'heures estimes-tu la finalisation du portage ?

…wallet products Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

carmenbianca · 2025-01-23T14:58:51Z

@legalsylvain i added one important test for taxation. this should technically never be needed, but it's good to know that everything is correctly implemented.

ping for review :)

edit: of course it breaks in CI but not locally...

legalsylvain · 2025-01-23T16:14:22Z

edit: of course it breaks in CI but not locally...

ahah ! let me know when it's green. Thanks !

legalsylvain · 2025-01-28T09:12:21Z

@carmenbianca : I'm not sure. Are you waiting for my review, or Do I have to wait the CI is green ?

thanks !

a

legalsylvain

thanks ! I'll take a look in the next week.

pos_customer_wallet/tests/test_balance.py

This assertion is different between the CI environment (4 elements) and local tests (3 elements). This discrepancy was introduced after the previous commit. Exactly why it is different, I do not know, but the assertion is not important enough to waste hours debugging. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

carmenbianca · 2025-03-10T09:01:47Z

hi @legalsylvain ! if you have time, this still needs some reviewing.

legalsylvain · 2025-03-10T11:35:32Z

hi @legalsylvain ! if you have time, this still needs some reviewing.

Work in progress !

I just finished a functional review. All is OK until session is closed. At this time, the balance of the customer become wrong. Use case :

sell Wallet product to customer (by invoice) : Balance : 0 -> 1000€ : OK
Open Point of Sale, sell to customer 100€ : Balance 1000 -> 900€ : OK
Close Point of sale : Balance 900 -> 1000€ : KO.

What do you think ?

carmenbianca changed the title ~~[16.0][MIGpos customer wallet~~ [16.0][MIG] pos_customer_wallet Jul 11, 2023

carmenbianca marked this pull request as draft July 11, 2023 14:14

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 06ace62 to 1109db1 Compare September 7, 2023 09:38

github-grap-bot added the needs review label Sep 7, 2023

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 1109db1 to afb08db Compare September 7, 2023 09:46

carmenbianca and others added 24 commits September 7, 2023 16:27

[ADD] pos_customer_wallet

d3ddd79

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Display wallet balance on POS payment screen

35077ff

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Make global module toggle available in pos…

4139829

….config Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Journal demo data

5321b00

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Mandate selected customer when using walle…

8af348e

…t payment method Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Check sufficient balance before POS purchase

c4cc880

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] account_customer_wallet: Write account_wallet to res.company in…

4c65655

…stead of settings Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_account_wallet: Update wallet balance in POS

843035c

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] pos_customer_wallet: Update write_date on computation of wallet…

9441262

… balance Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[REM] account_customer_wallet: Remove some fields and api.depends lines

5acebf8

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Tests

45868c3

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[REF] pos_customer_wallet: Re-implement wallet computation using part…

789a5fa

…ner._invoice_total algorithm Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[REM] account_customer_wallet: Custom wallet toggle; depend on whethe…

2a5aabb

…r account is set instead Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] account_customer_wallet: Search balance on all partners in fami…

32556c1

…ly tree Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] pos_customer_wallet: Avoid null error when no customer is selected

d9123bf

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] account_customer_wallet: README.rst

ce833b0

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[UPD] Update pos_customer_wallet.pot

63f8257

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

pos_customer_wallet 12.0.1.0.1

748bc6a

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] SCRLfs → SC

158bbe9

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[ADD] pos_customer_wallet: Show balance on ticket

c87c8db

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] pos_customer_wallet: typo

a0e7e0e

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[REF] *_customer_wallet: Create partner.get_all_partners_in_family

c381b9c

Signed-off-by: Carmen Bianca Bakker <[email protected]> Signed-off-by: Carmen Bianca BAKKER <[email protected]>

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch 2 times, most recently from 228bd28 to 7f85b83 Compare May 27, 2024 12:14

carmenbianca added 9 commits May 27, 2024 14:23

[MIG] pos_customer_wallet: Migration to 13.0

1818433

base_suspend_security's functionality is wrapped into Odoo's sudo by default

[MIG] pos_customer_wallet: Migration to 14.0

cdcac46

[MIG] pos_customer_wallet: Migration to 15.0

64249a0

[MIG] pos_customer_wallet: Migration to 16.0

e0e8249

[REM] pos_customer_wallet: Remove bank statement line method of walle…

7d1cf54

…t computation The pos session does not create these anymore. It creates pos.payment records instead. Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[FIX] pos_customer_wallet: Add some copyright headers

b4c8c4c

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[IMP] pos_customer_wallet: Some user-facing documentation

3196438

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[IMP] pos_customer_wallet: Slightly refactor tests to use the same se…

c670d0f

…ssion Signed-off-by: Carmen Bianca BAKKER <[email protected]>

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 7f85b83 to dcf77e8 Compare May 27, 2024 12:24

carmenbianca requested a review from legalsylvain May 27, 2024 12:27

carmenbianca added 3 commits January 23, 2025 15:54

[IMP] pos_customer_wallet: After closing, correctly handle purchased …

e8d9c78

…wallet products Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[REF] pos_customer_wallet: Refactor to .esm.js

ae86302

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[IMP] pos_customer_wallet: Add taxation test

2038376

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from dcf77e8 to 2038376 Compare January 23, 2025 14:55

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 2038376 to ae86302 Compare January 24, 2025 10:36

legalsylvain reviewed Feb 10, 2025

View reviewed changes

a Outdated Show resolved Hide resolved

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from 2289271 to ab6e825 Compare February 10, 2025 10:29

legalsylvain reviewed Feb 10, 2025

View reviewed changes

pos_customer_wallet/tests/test_balance.py Outdated Show resolved Hide resolved

carmenbianca force-pushed the 16.0-mig-pos_customer_wallet branch from ab6e825 to a77446d Compare February 10, 2025 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[16.0][MIG] pos_customer_wallet #300

[16.0][MIG] pos_customer_wallet #300

Uh oh!

carmenbianca commented Jul 11, 2023 •

edited

Loading

Uh oh!

codecov-commenter commented Sep 7, 2023 •

edited

Loading

Uh oh!

legalsylvain commented May 27, 2024

Uh oh!

polchampion commented Sep 18, 2024

Uh oh!

carmenbianca commented Jan 23, 2025 •

edited

Loading

Uh oh!

legalsylvain commented Jan 23, 2025

Uh oh!

legalsylvain commented Jan 28, 2025

Uh oh!

Uh oh!

legalsylvain left a comment

Uh oh!

Uh oh!

carmenbianca commented Mar 10, 2025

Uh oh!

legalsylvain commented Mar 10, 2025

Uh oh!

Uh oh!

[16.0][MIG] pos_customer_wallet #300

Are you sure you want to change the base?

[16.0][MIG] pos_customer_wallet #300

Uh oh!

Conversation

carmenbianca commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Odoo task (if applicable)

Checklist before approval

Uh oh!

codecov-commenter commented Sep 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

legalsylvain commented May 27, 2024

Uh oh!

polchampion commented Sep 18, 2024

Uh oh!

carmenbianca commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legalsylvain commented Jan 23, 2025

Uh oh!

legalsylvain commented Jan 28, 2025

Uh oh!

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

carmenbianca commented Mar 10, 2025

Uh oh!

legalsylvain commented Mar 10, 2025

Uh oh!

Uh oh!

carmenbianca commented Jul 11, 2023 •

edited

Loading

codecov-commenter commented Sep 7, 2023 •

edited

Loading

carmenbianca commented Jan 23, 2025 •

edited

Loading