Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gitea private secure template and Passbolt template #4524

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

UserCr4ig
Copy link

Changes

  • Added new Gitea template with secure configuration for private hosting
  • Added Passbolt template for team password management
  • Updated service-templates.json to include new templates

Issues

  • While reviewing existing Gitea templates, I noticed significant security concerns in their default configurations. Rather than modifying existing templates (which could impact current deployments and require extensive environment changes), I opted to create a new "gitea-private-secure" template that implements security best practices by default. This includes:
    • Enforced private visibility (this was public by default)
    • Brute force protection
    • Session security
    • API restrictions
    • Attack surface reduction
    • User access controls

This approach allows existing users to maintain their current setups while providing a secure alternative for new deployments.

@peaklabs-dev peaklabs-dev added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Dec 9, 2024
Copy link
Member

@peaklabs-dev peaklabs-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you please change the following things:

  1. Please do not commit service-templates.json to the PR.
  2. Can you please add your security enhancement to the current Gitea template, as already deployed instances will not get the new template, only new deployments will use the new compose file, so there is no need to create a separate template for this.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Service Issues requesting or PRs adding/fixing service templates. 💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants