chore: add registry auth to docker image apps #4187
Conversation
|
I would like some input on this, I have some questions ex:
|
No it should only show like on GitHub actions for example -> Like REGISTRY_SECRET only show the env or so not the value
Yes please - all sensitive data needs to be encrypted (passwords tokens etc), very simple to implement thanks to Laravel
What issues are you facing, maybe DM me or open discussion on Discord |
OSINTRoach
force-pushed
the
docker-image-login
branch
from
71856c8
to
1d2d88e
Compare
OSINTRoach
force-pushed
the
docker-image-login
branch
from
1d2d88e
to
ebf2072
Compare
|
Thanks for taking the time to improve the PR. Overall the PR is coming along nicely.
If you need help with anything just let me know. |
peaklabs-dev
added
💤 Waiting for feedback
| public ?string $username = null; | ||
| public ?string $token = null; | ||
|
|
||
| protected $rules = [ |
There was a problem hiding this comment.
Please use the new validation attribute of Livewire as this syntax is deprecated. https://livewire.laravel.com/docs/validation#validate-attributes
| try { | ||
| // setup | ||
| $this->dockerImage = $this->application->docker_registry_image_name; | ||
| if (str($this->application->docker_registry_image_tag)->isEmpty()) { |
There was a problem hiding this comment.
docker_registry_image_tag why do we call it docker registry image tag I think dockerImageTag will be sufficient as this is available on all repos (would be great if you could rename it.
| public ?string $username = null; | ||
| public ?string $token = null; | ||
|
|
||
| protected $rules = [ |
There was a problem hiding this comment.
Please also use the new validate attribute syntax
| <div class="w-fit"> | ||
| <x-forms.checkbox wire:model.live="application.docker_use_custom_registry" | ||
| id="application.docker_use_custom_registry" | ||
| helper="Select a registry to pull the image from." label="Use Private Registry" /> |
There was a problem hiding this comment.
Please also add the private registry section to all git deploy types under docker image:
-> Somewhere down here (Nixpacks, docker Image and Dockerfile have this).
There was a problem hiding this comment.
One more thing: A dropdown is a bit limited, if you have docker hub and ghrc private images it should probably be a multiselect so you can select multiple private registries and these will be used.
|
|
I also found an Icon you can use, same one as in docker desktop: https://tablericons.com/icon/cube-3d-sphere. |
Changes