-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow disabling default redirect, set status to 503 #3845
base: next
Are you sure you want to change the base?
Conversation
static::retrieved(function ($server) { | ||
if (!isset($server->proxy->redirect_enabled)) { | ||
$server->proxy->redirect_enabled = true; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better way to make sure this is true by default?
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Changes
setupDefaultRedirect
method to only do things once, it was a bit hard to follow before.Issues
proxy->redirect_rewrite
option too to display a custom page without changing the url?