Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Improve cron validation function, cron helpers and cron input errors #3120

Draft
wants to merge 13 commits into
base: next
Choose a base branch
from

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Aug 18, 2024

Changes:

TODO:

  • Fix: yearly is not a valid CRON expression or any custom expression error internally
  • Fix: cron Input for application/ services when edit seems to have no validation
  • Improve all helpers for corn inputs (backup, cron job, auto update, update check, server cleanup)
  • Improve error dispatches for cron inputs (backup, cron job, auto update, update check, server cleanup)
  • Improve validation function for cron inputs -> use the right function!
  • Improve cron validation function generally
  • Fix: 11 18 *** this is invalid -> because of missing spaces.
  • Feat: cron auto formatting -> automatically add spaces between cron (fixes the error for 11 18 ***)
  • Feat: add more default crons?
  • Feat: New improve docs (new PR on docs)
  • fix [Bug]: Setting database backup frequency to "hourlyy" is a one-way update #4463

@coollabsio coollabsio deleted a comment from gitguardian bot Sep 26, 2024
@coollabsio coollabsio deleted a comment from gitguardian bot Dec 12, 2024
Copy link

gitguardian bot commented Dec 16, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant