Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ntfy notifications #2704

Open
wants to merge 8 commits into
base: next
Choose a base branch
from
Open

Conversation

frostplexx
Copy link

This PR adds support for ntfy.sh notifications.

@Lukap22
Copy link

Lukap22 commented Jul 16, 2024

I need this!

@andrasbacsai andrasbacsai added the ⚙️ Service Issues requesting or PRs adding/fixing service templates. label Aug 27, 2024
@vinicius507
Copy link

What are the plans for this integration?

@peaklabs-dev peaklabs-dev added 🛠️ Feature Issues requesting a new feature. and removed ⚙️ Service Issues requesting or PRs adding/fixing service templates. labels Sep 3, 2024
Copy link

gitguardian bot commented Sep 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@peaklabs-dev
Copy link
Member

@frostplexx Sorry for the late review. I have completed the refactored notifications for the next release and if you still have time and are able to work on this PR, it would be necessary to adjust your PR according to the new notification handling. You can check my PR to see the migrations and models added: #4525 and you can check out the next branch for now to see the new way of implementing notifications.

It would be great if you could adjust your PR accordingly. If you are unable to do so, please let me know so I can close this PR.

@peaklabs-dev peaklabs-dev added the 💤 Waiting for changes PRs awaiting changes from the author. label Dec 11, 2024
@compgeniuses
Copy link

the new refactored notifications is superb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Feature Issues requesting a new feature. 💤 Waiting for changes PRs awaiting changes from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants