Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VK.COM video support #1876

Closed
wants to merge 2 commits into from

Conversation

nitruxa
Copy link

@nitruxa nitruxa commented Aug 27, 2024

No description provided.

@nitruxa
Copy link
Author

nitruxa commented Aug 30, 2024

cc @cookpete :shipit:

Copy link

@Sergei53maestro Sergei53maestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vk.com/@id582780828

@nitruxa
Copy link
Author

nitruxa commented Oct 1, 2024

cc @luwes

@luwes
Copy link
Collaborator

luwes commented Oct 1, 2024

thanks for the contribution @nitruxa !

However this will unlikely to be merged soon. We're trying to figure out how to release a v3 that will support media-chrome for custom themes. See #1843

@nitruxa
Copy link
Author

nitruxa commented Oct 1, 2024

@luwes why should v3 block us from adding other custom themes for now? 😵‍💫

@luwes
Copy link
Collaborator

luwes commented Oct 1, 2024

we're not adding new providers / players because v3 will not support the old player API design.
it will built on the HTMLMediaElement API design like the https://github.com/muxinc/media-elements here.
see this PR #1886

you can also use the VK player you have in this PR with
https://github.com/cookpete/react-player#adding-custom-players

@nitruxa
Copy link
Author

nitruxa commented Oct 1, 2024

I just embed its iframe for now, should be fine. thanks @luwes

@nitruxa nitruxa closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants