Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI #1654

Merged
merged 8 commits into from
Aug 25, 2023
Merged

CI #1654

merged 8 commits into from
Aug 25, 2023

Conversation

jessp01
Copy link
Contributor

@jessp01 jessp01 commented Jul 25, 2023

Use GH actions for CI.

All tests pass with node 16 but the build jobs seem to fail with higher versions. Please see https://github.com/jessp01/react-player/actions/runs/5662727275/job/15343189737 for an example of the failure.

@heff
Copy link
Collaborator

heff commented Aug 25, 2023

LGTM, thanks @jessp01! I ran into the same node version issue when setting up the repo for the first time and found this answer. But we should figure out how to get the build up to date.

@heff heff merged commit 7034036 into cookpete:master Aug 25, 2023
@jessp01
Copy link
Contributor Author

jessp01 commented Aug 30, 2023

Cheers, @heff. Now that you've merged it, I can have a look at the build issue. While we're conversing, any thoughts on #1653?

@jessp01
Copy link
Contributor Author

jessp01 commented Aug 30, 2023

@heff , please see #1664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants