Skip to content

TemporalDensityCSV: Re-use dual access calculations and allow multiple thresholds #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 11, 2025
Merged

TemporalDensityCSV: Re-use dual access calculations and allow multiple thresholds #964

merged 5 commits into from
Apr 11, 2025

Conversation

trevorgerhardt
Copy link
Member

@trevorgerhardt trevorgerhardt commented Apr 10, 2025 •
edited
Loading

  • Re-use the previously calculated dual access threshold values when writing out a CSV file.
  • Allow more than one dual access threshold to be used when creating and writing the CSV. Uses the heading dual ${threshold} for the column in the CSV.
  • Additionally, allow a TemporalDensityCSV to be created without any thresholds specified.

@trevorgerhardt trevorgerhardt marked this pull request as ready for review April 10, 2025 23:45
@trevorgerhardt trevorgerhardt mentioned this pull request Apr 10, 2025
Merged
Base automatically changed from dual-together to dev April 11, 2025 01:14
ansoncfit
ansoncfit approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@ansoncfit ansoncfit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- the change to allow multiple thresholds to be written to a CSV ended up being smaller than I expected.

@trevorgerhardt trevorgerhardt merged commit 26d179b into dev Apr 11, 2025
3 checks passed
@trevorgerhardt trevorgerhardt deleted the temporal-csv branch April 11, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansoncfit ansoncfit ansoncfit approved these changes

@abyrd abyrd Awaiting requested review from abyrd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevorgerhardt @ansoncfit