Adding support for protocol handler#3870
Adding support for protocol handler#3870marcellintacite wants to merge 2 commits intoconversejs:masterfrom
Conversation
marcellintacite
force-pushed
the
add-protocol-handler
branch
from
28e327a to
5b41936
Compare
|
Looking good so far @marcellintacite! Please also remember to update the DOAP file to mention support for the new XEP |
|
@jcbrand Hello, i would like your review for the test i wrote |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@jcbrand i need your help on tests so i can get done with this PR. I am facing some errors |
marcellintacite
force-pushed
the
add-protocol-handler
branch
2 times, most recently
from
67fa8c7 to
cd88326
Compare
|
Hello @jcbrand i have fixed test issue |
|
Hi @jcbrand , could you please provide an update on this Pull Request? I'd like to know what's left to address so we can proceed with merging it. |
jcbrand
left a comment
jcbrand
left a comment
There was a problem hiding this comment.
I took some time to review this PR. Thanks a lot for the work you've done on this so far.
Please have a look at this comment first:
https://github.com/conversejs/converse.js/pull/3870/changes#r2667473276
Since it's the most important one of my review.
It's important that we stick to the plugin architecture and separation of concerns, which is why I think you need to move the functionality to separate plugins.
The roster-related stuff should go into the rosterview plugin and the other actions can go into chatboxviews (which encompasses both MUC and 1:1 whereas chatview is only 1:1).
Let me know if you have any questions or if anything is unclear.
- Register XMPP protocol handler in src/index.js - Implement URI parsing in chatview/utils.js - Add plugin-specific routing via xmppURIAction event - Add message sending support in chatboxviews plugin - Add roster contact addition in rosterview plugin - Add comprehensive unit tests for all features - Follow plugin architecture for separation of concerns
marcellintacite
force-pushed
the
add-protocol-handler
branch
from
8192ce9 to
8d0a725
Compare
|
Hi @jcbrand , i have updated the PR can you check please |
2 participants
Here's a draft for this issue : #1247
This merge request adds support for handling xmpp: protocol links in Converse.js, allowing users to click links like xmpp:user@example.com to automatically open a chat with the specified JID if logged in. This enhances user experience by enabling seamless integration with external XMPP links (e.g., from emails, websites, or other apps).
Before submitting your request, please make sure the following conditions are met:
CHANGES.mddocument it in
docs/source/configuration.rstwith
make checkor you can run them in the browser by runningmake serveand then opening
http://localhost:8000/tests.html.