[FIX] Sponsor logos overlapping on Contacts page#3858
Open
marcellintacite wants to merge 2 commits intoconversejs:masterfrom
Open
[FIX] Sponsor logos overlapping on Contacts page#3858marcellintacite wants to merge 2 commits intoconversejs:masterfrom
marcellintacite wants to merge 2 commits intoconversejs:masterfrom
Conversation
Member
|
Hi @marcellintacite, could you please fix the merge conflict in this branch? |
Contributor
Author
I am working on it and also i have issue with test. I am trying to figure it out |
Member
|
There is only a change in CHANGES.md now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the issue : #3800
The original layout used Bootstrap's grid system (row, row-cols-*, and col), which was causing the logos to shrink and overlap before they wrapped. This was due to the default flex-shrink behavior of the col class.
This PR replaces the grid classes with a simpler, more flexible flexbox approach. The parent ul element now uses d-flex and flex-wrap, allowing the list items to wrap to a new line naturally when the container shrinks.
By also adding a gap-4 class to the container, we ensure there is consistent space between the logos, preventing them from touching or overlapping.
Before submitting your request, please make sure the following conditions are met:
CHANGES.mddocument it in
docs/source/configuration.rstwith
make checkor you can run them in the browser by runningmake serveand then opening
http://localhost:8000/tests.html.