Skip to content

Fix phpstan CI failures on PHP 8.1#22

Closed
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
ohmyfelix:fix/phpstan-php81-compat
Closed

Fix phpstan CI failures on PHP 8.1#22
ohmyfelix wants to merge 1 commit intocontributte:masterfrom
ohmyfelix:fix/phpstan-php81-compat

Conversation

@ohmyfelix
Copy link
Contributor

Summary

  • pin contributte/qa to ^0.3.2 so the Phpstan workflow can install dependencies on PHP 8.1
  • replace direct deprecated Symfony listener/interface class-constant references with guarded class-string literals
  • harden schema/reflector type checks and remove stale Phpstan ignore patterns that are no longer needed

Motivation

The Phpstan workflow currently fails before analysis starts because composer update resolves contributte/qa v0.4.0, which requires PHP >=8.2, while CI runs Phpstan on PHP 8.1.

Testing

  • make phpstan
  • full test suite

@ohmyfelix
Copy link
Contributor Author

Already implemented, closing this pull request.

@ohmyfelix ohmyfelix closed this Mar 9, 2026
@ohmyfelix ohmyfelix deleted the fix/phpstan-php81-compat branch March 9, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant