refactor: optimize filter condition handling for NextrasDataSource#1200
Open
emololftw wants to merge 1 commit intocontributte:masterfrom
Open
refactor: optimize filter condition handling for NextrasDataSource#1200emololftw wants to merge 1 commit intocontributte:masterfrom
emololftw wants to merge 1 commit intocontributte:masterfrom
Conversation
Contributor
Author
|
related to: #298 |
Member
Contributor
Author
|
👉👈 |
Member
|
This really imho does not make any sense. When there is some spetial behaviour in Nextras, in should be handled in Nextras ano not in the parent abstract class. |
Member
|
@emololftw Ping. |
Contributor
Author
|
@radimvaculik @paveljanda I'm so sorry for my late response. Of course, you're right - this specific behavior is useless to keep in the general class. Would you be open to accepting it if I implement it in the Nextras class case instead? |
Member
|
@emololftw Please. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Refactor dataSource filtering for NextrasDataSource to use Collection function
Refactored the filtering logic in NextrasDataSource to utilize the Collection function within filterCondition. This change improves code consistency and leverages existing Collection utilities.
Changes:
Working cases:
PS: sorry, I accidentally deleted my last personal repository