Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open visibility for better inheritance usage. #1073

Closed
wants to merge 1 commit into from

Conversation

jannovy
Copy link

@jannovy jannovy commented Mar 23, 2023

I have to customize DoctrineDataSource class to improve Doctrine performance. This is the most simple way how to embed my own DoctrineDataSource to DataModel and DataGrid.

@radimvaculik
Copy link
Member

@jannovy Why don't you use method setDataSource? I don't get your proposal changes.

@jannovy
Copy link
Author

jannovy commented Apr 17, 2023

@radimvaculik The goal is to use a custom implementation of the DoctrineDataSource class. So I have to create child class of DataModel to replace \Ublaboo\DataGrid\DataSource\DoctrineDataSource by my own \App\DataGrid\DataSource\DoctrineDataSource

Or is there some other shortcut ?

@radimvaculik
Copy link
Member

radimvaculik commented May 6, 2023

@jannovy Did you check this PR? #1038 Does it solve your problem?

@radimvaculik
Copy link
Member

@jannovy Ping.

@jannovy
Copy link
Author

jannovy commented Jun 20, 2023

@radimvaculik Yes, this is solution for me.

@radimvaculik
Copy link
Member

@jannovy Can we close this issue?

@jannovy
Copy link
Author

jannovy commented Jun 20, 2023

@radimvaculik Yes, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants