Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effective DataModel when used with Rest API based datasource #1037

Closed
wants to merge 1 commit into from
Closed

Effective DataModel when used with Rest API based datasource #1037

wants to merge 1 commit into from

Commits on Jul 16, 2022

  1. Effective DataModel when used with Rest API based datasource 

     When Datagrid is used with common database like data sources, it is common, that receiving total count for paging cost extra one query. When working with REST API datasource it is best practice that response for getting resource collection contains information about total count.

 For the purposes of creating query only offset and limit is necessary. The total count is necessary for two reasons. First is to show UI component with list of pages. Second to check if requested page number is not higher that collection maximum.

 The problem with current model is, that the order in witch get total count is received cost two calls on Rest API endpoint instead of one. I suggest to move call of getCount() method after getting data. When working with DB, it does not matter if the getCount() call is sooner or later with performance in mind.

 If this kind of change is too big BC break, another possibility would be to create interface for data model and enable change of DataModel. One will be more strict in terms of pagination overflow and another less.
    @VojtechBuba
    VojtechBuba committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    caafe4a View commit details
    Browse the repository at this point in the history