fix: truncate tagToString to max filename len
#5632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Erichsen
requested review from
tomasz-stefaniak
and removed request for
a team
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:M
|
@sestinj I don't believe this should break any existing indexes since it only uses the new logic if the tagName would have thrown an error using the old logic. But worth a sanity check. |
Patrick-Erichsen
requested review from
sestinj
and removed request for
tomasz-stefaniak
sestinj
previously requested changes
May 12, 2025
| @@ -4,7 +4,7 @@ import { RunResult } from "sqlite3"; | |||
|
|
|||
| import { IContinueServerClient } from "../../continueServer/interface.js"; | |||
| import { Chunk, IndexTag, IndexingProgressUpdate } from "../../index.js"; | |||
| import { DatabaseConnection, SqliteDb, tagToString } from "../refreshIndex.js"; | |||
| import { DatabaseConnection, SqliteDb } from "../refreshIndex.js"; | |||
There was a problem hiding this comment.
nothing to do in your PR here, but reminder that we should add prettier as a CI step to resolve these messy diffs
dosubot
bot
added
size:L
3 tasks
RomneyDa
approved these changes
May 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #5594
Summary by mrge
Updated the tagToString function to truncate long strings, making sure table names and identifiers stay within safe filename limits. This prevents errors from overly long paths, especially in dev containers.