Skip to content

Clean up DataLogger and use auth by default #5623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented May 12, 2025

Description

Clean up DataLogger and use auth by default

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Summary by mrge

Refactored the DataLogger for better readability and now use authentication by default when sending remote logs.

  • Refactors
    • Split logging logic into smaller methods.
    • Simplified how remote destinations are handled.
    • Default to using the Authorization header for remote log requests.

@sestinj sestinj requested a review from a team as a code owner May 12, 2025 04:47
@sestinj sestinj requested review from RomneyDa and removed request for a team May 12, 2025 04:47
Copy link

netlify bot commented May 12, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 130fdf1
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/68223bc36d4ba800089a6a50

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 12, 2025
RomneyDa
RomneyDa previously approved these changes May 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 12, 2025
@sestinj
Copy link
Contributor Author

sestinj commented May 14, 2025

@RomneyDa gonna need another review on this one.

If you would have gotten to this anyway and the ping doesn't help bring it to the top of your inbox in any useful way, lmk, I will stop doing this.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 15, 2025
@RomneyDa
Copy link
Collaborator

pings never minded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants