fix: improve handling of Launch deployment file upload size errors#122
Merged
Harshi-Shah-CS merged 1 commit intodevelopmentfrom Mar 25, 2026
Merged
fix: improve handling of Launch deployment file upload size errors#122Harshi-Shah-CS merged 1 commit intodevelopmentfrom
Harshi-Shah-CS merged 1 commit intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Improves UX for Launch deployment failures by detecting file-upload-size-related GraphQL error codes and emitting a clearer, user-oriented message instead of dumping the raw error.
Changes:
- Added utilities to extract Launch deployment-related error codes from GraphQL/Apollo error shapes and detect file-size-related failures.
- Updated adapter error handling to show a dedicated file-size limit message for detected cases.
- Added Jest coverage for the new utility helpers and the updated BaseClass error-handling paths.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/util/deployment-errors.ts | Introduces code-collection + detection helpers and a shared user-facing message for file size failures. |
| src/util/deployment-errors.test.ts | Adds unit tests covering code extraction from multiple nested error shapes. |
| src/adapters/base-class.ts | Uses the new detection helper to replace raw error logging with a friendlier message for file-size-related failures. |
| src/adapters/base-class.test.ts | Adds tests asserting the new logging behavior in deployment creation and project creation error flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chhavi-Mandowara
approved these changes
Mar 25, 2026
dhruvparekh12
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: improve handling of Launch deployment file upload size errors