fix: skip text wrappers when mark value is falsy - #104
Open
SachinAryaMckinsey wants to merge 93 commits into
Open
fix: skip text wrappers when mark value is falsy#104SachinAryaMckinsey wants to merge 93 commits into
SachinAryaMckinsey wants to merge 93 commits into
Conversation
fix: encode social-embeds and embeds src urls
fix: escape html entities in attr values
feat: handle invalid attr key-values
…conversion to html
…tribute is passed throug as options
feat: hr as a tag not data type
Release version 3.0.0
No.of br tags should match /n on shift+enter
[RT-611][bug] Moved the constants to separate file and used them to create local vars to make changes
[RT-611][bug] Moved the constants to separate file and used them to create local vars to make changes
feat: indent support
Update package.json
- Pin lodash 4.18.1; npm overrides for omit-deep-lodash, form-data, @tootallnate/once transitive issues - Upgrade esbuild beyond GHSA advisory range; bump uuid to ^11.x - Move Jest to 29 with jest-environment-jsdom; ts-jest and jsdom updates - Add jest.setup.js for TextEncoder/TextDecoder under jsdom - Set skipLibCheck in tsconfig for stable declaration builds Co-authored-by: Cursor <cursoragent@cursor.com>
chore(deps): security fixes and toolchain updates [EXP-406]
chore: ci rules
fix: jsdom overrides
Only apply a text wrapper (e.g. bold/italic/underline) when its value is truthy, so marks explicitly set to false no longer wrap the text. Adds tests covering falsy and mixed mark values. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
toRedactorwhere text marks (e.g.bold,italic,underline) were applied even when their value was explicitlyfalse. Previously, the code only checked whether the mark key existed on the node, not whether its value was truthy — so a child like{ text: "foo", bold: false }would still be wrapped in<strong>.Changes
src/toRedactor.tsx: Added a truthiness check so a text wrapper is only applied when the mark's value is truthy: